Add Missing Countries Data for Character Creation Nationality Selection#269
Closed
ThembaMahlangu wants to merge 1 commit into
Closed
Add Missing Countries Data for Character Creation Nationality Selection#269ThembaMahlangu wants to merge 1 commit into
ThembaMahlangu wants to merge 1 commit into
Conversation
Member
|
Doesn't this already get stored at the top of the file upon first execution? |
Contributor
|
@Qwerty1Verified Yes line 3 |
Author
|
Honestly I wouldn't have done this if this was not so buggy, On character creation you have less than 80% chances of the nationality data to load so I got fed up and this way works all the times |
Author
|
@ChristianBDev @Qwerty1Verified You can verify what I mean above, because just commenting won't help figure it out |
Contributor
|
This request should be closed, this is already added to the script/code |
Z3rio
suggested changes
Aug 1, 2025
Contributor
Z3rio
left a comment
There was a problem hiding this comment.
This PR should be closed, as the logic has not been changed in any way at all from its current form.
Unless we can provide steps on how to actually recreate the issue concerning the Countries variable not loading correctly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe Pull request
This PR fixes an issue where the nationality selection dropdown was empty during character creation. The fix modifies the
GetNumberOfCharactersserver callback to properly load and send the countries data from countries.json to the client. This is a critical fix as it restores core functionality of the character creation system, allowing players to properly select their character's nationality.The fix:
This should be included in the core as nationality selection is a fundamental feature of character creation and this fix restores intended functionality without introducing new features or dependencies.
Related Issue: [If there's a GitHub issue, reference it here]
Questions:
Have you personally loaded this code into an updated qbcore project and checked all it's functionality? [yes]
Does your code fit the style guidelines? [yes]
Does your PR fit the contribution guidelines? [yes]