feat: surface chart-default and overlay yaml comments under Show docs toggle#57
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DefaultCommentfield onFlatValueEntry, populated bynewFlatValues, kept separate fromCommentso the chart-side annotation survivesRebuildUnifiedEntriesrewritingCommentto overlay-side textDefaultCommentas a caption above each row in the left (chart) panel whenShowDocsis onShow commentstoShow docsacross the checkbox label, Go API, layout constants, and theshowDocsJSON preference key{}or[]placeholder to a section when the overlay populates that key, so the section comment editor applies and children group under itIsEmptyContainerhelper onFlatValueEntryalong withemptyMapValueandemptyListValueconstantsSortByFilePositionswhen an entry has no recorded position so overlay-added descendants sort beside the section header rather than the alphabetic tailCommentandDefaultCommentin the search cache so queries match documentation prose from either source+chip on extras rows and deleteextra_chip.go; cyan tint and the placeholder text still signal extras statusnot in chartglyph form to plainnot in chartand render it for both leaf and section extras rows