fix: use original jina de model instead of fp16 due to onnxruntime up…#623
fix: use original jina de model instead of fp16 due to onnxruntime up…#623
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThese changes update the model configuration and compatibility warnings for the jina-embeddings-v2-base-de model across two files. The first file increases the reported model size from 0.32 GB to 0.64 GB and updates the ONNX artifact path from Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Starting from
onnxruntime1.23,model_fp16.onnxstarted failing withonnxruntimenot supporting a custom layer in fp16 version ofjinaai/jina-embeddings-v2-base-de, in order to mitigate this issue, I propose to replace fp16 model with the original fp32