Skip to content

Fix: Remove unused imports and variables#1142

Open
anaslimem wants to merge 1 commit intoqdrant:masterfrom
anaslimem:fix/remove-unused-imports
Open

Fix: Remove unused imports and variables#1142
anaslimem wants to merge 1 commit intoqdrant:masterfrom
anaslimem:fix/remove-unused-imports

Conversation

@anaslimem
Copy link
Copy Markdown

Description

This PR fixes linting issues identified by ruff by removing unused imports and variables that were causing code quality warnings.

Changes Made

  • conversions/common_types.py: Removed unused sys import
  • conversions/conversion.py: Removed unused Sequence import from typing
  • embed/schema_parser.py: Removed unused exception variable e in ImportError handler

Motivation

These changes improve code quality by:

  • Reducing unnecessary imports that consume memory
  • Making the codebase cleaner and easier to maintain
  • Fixing linting warnings detected by ruff check

Testing

  • All existing unit tests pass
  • ruff check confirms the linting issues are resolved
  • No functional changes - purely cleanup

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • Code quality improvement
  • New feature
  • Breaking change

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • Any dependent changes have been merged and published

- Remove unused sys import from conversions/common_types.py
- Remove unused Sequence import from conversions/conversion.py
- Remove unused exception variable from embed/schema_parser.py
@netlify
Copy link
Copy Markdown

netlify bot commented Jan 17, 2026

Deploy Preview for poetic-froyo-8baba7 ready!

Name Link
🔨 Latest commit 77a9550
🔍 Latest deploy log https://app.netlify.com/projects/poetic-froyo-8baba7/deploys/696b89a866f9a90008f35517
😎 Deploy Preview https://deploy-preview-1142--poetic-froyo-8baba7.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Jan 17, 2026

📝 Walkthrough

Walkthrough

This pull request removes unused imports and an unused exception alias across three files in the qdrant_client package. Specifically: removed sys import from common_types.py, removed Sequence from typing imports in conversion.py, and removed the unused exception alias in schema_parser.py. All changes are cleanup-only with no modifications to runtime behavior, control flow, APIs, or public entity declarations.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Fix: Remove unused imports and variables' directly and concisely summarizes the main change in the changeset.
Description check ✅ Passed The description clearly explains the linting fixes, lists all three files changed, details the specific removals, and explains the motivation and testing performed.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant