ci: add release sanity check workflow#1187
ci: add release sanity check workflow#1187Pawansingh3889 wants to merge 3 commits intoqdrant:masterfrom
Conversation
✅ Deploy Preview for poetic-froyo-8baba7 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthroughAdds a new GitHub Actions workflow "Release Sanity Check" that triggers on tag pushes matching Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.github/workflows/release-sanity-check.yml:
- Around line 36-43: The CI step tries to access qdrant_client.__version__ which
may not be defined and can raise AttributeError; change the workflow to avoid
reading __version__ directly (e.g., import qdrant_client and use
getattr(qdrant_client, '__version__', 'unknown') or remove the version print
altogether) and keep the validation of the QdrantClient class by importing
QdrantClient; ensure the workflow prints a safe fallback string instead of
accessing qdrant_client.__version__ so valid wheels don't fail CI.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: b9aeb3b7-731d-495d-bcdb-dc630c49e51d
📒 Files selected for processing (1)
.github/workflows/release-sanity-check.yml
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.github/workflows/release-sanity-check.yml:
- Around line 38-42: The run step's multi-line python -c string is malformed:
line with print(...) (the call using version("qdrant-client")) is mis-indented
and the inner double quotes conflict with the outer double-quoted YAML string.
Fix by converting the value for the run key to a YAML block scalar (|) or use
single quotes for the outer shell string and escape inner quotes, then align all
python lines under the same indentation; ensure the python -c invocation
includes the full script (import qdrant_client, from importlib.metadata import
version, print(f'qdrant-client {version("qdrant-client")} imported
successfully'), from qdrant_client import QdrantClient) within the same properly
quoted/indented block so YAML parses and the Qdrant import check runs.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 142e9444-bfc5-401e-be63-92b43cb49568
📒 Files selected for processing (1)
.github/workflows/release-sanity-check.yml
All Submissions:
Contributions should target the dev branch. Did you create your branch from dev?
Have you followed the guidelines in our Contributing document?
Have you checked to ensure there aren't other open Pull Requests for the same update/change?
New Feature Submissions:
Does your submission pass tests?
Have you installed pre-commit with pip3 install pre-commit and set up hooks with pre-commit install?
Closes #958
Adds a CI workflow that catches broken releases before they hit PyPI:
Builds the package, installs the wheel in a clean venv
Verifies import qdrant_client works
Checks that test deps (pytest, hypothesis, coverage) didn't leak
Runs across Python 3.9-3.12
Triggers on tags, PRs, and manual dispatch