Conversation
✅ Deploy Preview for poetic-froyo-8baba7 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThis pull request modifies the Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
| if value is None: | ||
| counts.append(0) | ||
| elif hasattr(value, "__len__") and not isinstance(value, str): | ||
| elif isinstance(value, list): |
There was a problem hiding this comment.
collections.abc.Sequence would probably be the generalized/more robust check here, but I guess it doesn't matter since we control what types go here
There was a problem hiding this comment.
when we add a point to a collection we serialize it to json and then deserialize, so I guess there should not be any tough types and list should be enough
#1189