Add testcontainers for integration testing#256
Open
nazq wants to merge 1 commit intoqdrant:masterfrom
Open
Conversation
- Add testcontainers 0.26 as dev dependency - Create test_utils module with QdrantContainer setup - Add integration.rs with containerized tests - Mark legacy integration tests as #[ignore] with guidance - Uses tmpfs for fast in-memory test execution
Member
|
@nazq Thank you for your submission! We already have test suite(s) that spin up Qdrant containers for us here: https://github.com/qdrant/qdrant/tree/master/tests For most tests I'd prefer to manually set up a Qdrant instance, because that gives us much more control during development. In most cases we want to test the local version, and that would save time not having to build a Docker image. Could you elaborate on what gaps are filled by your PR? I believe I don't fully get what you're trying to solve yet. 😃 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds testcontainers support for running integration tests without manual Docker setup. Tests automatically spin up a Qdrant container and clean up after completion.
Changes
New Files
tests/test_utils.rs- Qdrant container setup with tmpfs for fast in-memory testingtests/integration.rs- Integration tests using containerized QdrantModified Files
Cargo.toml- Added testcontainers 0.26 dev-dependencysrc/lib.rs- Marked legacy integration test as#[ignore]src/qdrant_client/collection.rs- Marked legacy integration test as#[ignore]src/qdrant_client/query.rs- Marked legacy integration test as#[ignore]Features
QDRANT_VERSIONenv varUsage
Test Plan