Remove --topic choices restriction in update-wikidata#271
Open
eloiferrer wants to merge 1 commit intoqlever-dev:mainfrom
Open
Remove --topic choices restriction in update-wikidata#271eloiferrer wants to merge 1 commit intoqlever-dev:mainfrom
eloiferrer wants to merge 1 commit intoqlever-dev:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've been using the update_wikidata.py command in our wikibase instance at MaRDI4NFDI.
I've noticed that the --topic argument in update-wikidata currently restricts values to two Wikidata-specific topics (eqiad.rdf-streaming-updater.mutation and codfw.rdf-streaming-updater.mutation). This prevents using the command with other Wikibase instances that have their own SSE streams with different topic names. Thus I would suggest removing the choices restriction while keeping the default unchanged, so existing Wikidata users are unaffected.
Feel free to disregard this PR if there is a reason for keeping this topic restriction.