Drop qmlobjdef alternative alias#21
Open
stephenmdangelo wants to merge 2 commits intoqmlweb:masterfrom
Open
Conversation
qmlobjdef supported only two components, a different format was needed to support assignments like Drag.hotSpot.x: width / 2. Now names with dot-syntax are parsed just like they are in pure js, so we now get nested dot-binary-expressions.
This allows property aliases to multi-level properties.
Member
|
/cc @akreuzkamp @akreuzkamp, what do you think? |
Member
|
@stephenmdangelo Is this still something you want to achieve? This needs changes in runtime, then. |
Member
Author
|
@ChALkeR I... don’t remember... I’ll look into it. I assume I had a usecase for it and either worked around it or maybe made the runtime change on some branch already. I’ll let you know. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This builds off of #19 adding deep-subproperties support to property aliases. I haven't made any corresponding changes to the runtime, but I'll do that if this makes sense.