Set WtW block of KKT matrix to -I in initialize_ipm#46
Merged
govindchari merged 2 commits intomainfrom Mar 11, 2026
Merged
Conversation
Download benchmark artifactsBenchmark Summary
Runtime regressions (> 5.0%)
Runtime improvements (> 5.0%)
|
Download benchmark artifactsBenchmark Summary
Runtime regressions (> 5.0%)
Runtime improvements (> 5.0%)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When qoco currently solves a problem and then
qoco_solveis called again, the KKT system contains the NT scaling from the final iteration of the first solve. Since the NT block of the KKT matrix is not reset, this leads to the behavior seen here: #45.This fix sets the NT block to -I in
initialize_ipmwhich fixes this issue.