Implemented iterator for partitions#3
Open
jacksonhenry3 wants to merge 1 commit intoquadrupleslap:masterfrom
Open
Implemented iterator for partitions#3jacksonhenry3 wants to merge 1 commit intoquadrupleslap:masterfrom
jacksonhenry3 wants to merge 1 commit intoquadrupleslap:masterfrom
Conversation
Contributor
|
Win in usability, but loss in performance: this implementation allocates a new vector at each iteration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This pull request impls the iterator trait for the
Partitionsstruct so it can be used as an iterator directly.Description:
Partitionsstruct.Vec<usize>, where each vec represents a partition.Testing:
Tested against the existing
oeistest case, ensuring that the iterator still yields the expected partitions for the first few entries of A000041.