Skip to content

cmcdv2/convertToCmcdV1 function from CML #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
juanmanuel-qualabs wants to merge 112 commits into
base: feature/cmcdv2
Choose a base branch
from
Draft

cmcdv2/convertToCmcdV1 function from CML #110

juanmanuel-qualabs wants to merge 112 commits into from

Conversation

@juanmanuel-qualabs
Copy link

@juanmanuel-qualabs juanmanuel-qualabs commented Jun 25, 2025

No description provided.

cotid-qualabs and others added 30 commits April 3, 2025 14:38
@cotid-qualabs
rename CmcdModel to CmcdController + extract CmcdController from HTTP…
ce3d857 
…Loader
@cotid-qualabs
add return to _cmcdRequestModeInterceptor
edd54b7
@cotid-qualabs
remove migrated code from HTTPLoader
a7f3ffe
@cotid-qualabs
rename CmcdModel unit test file
eaeeef6
@cotid-qualabs
add remove spaces on HTTPLoader
f11d89b
@cotid-qualabs
move cmcdRequestInterceptor setup to reset function
22e8e47
@cotid-qualabs
remove whitespace
251862d
@cotid-qualabs
remove whitespace
e8edb0d
@cotid-qualabs
remove whitespace
a269305
@cotid-qualabs
request mode fix
242683f
@sebastianpiq
refactor cmcdRequestModeInterceptor to return a new commonMediaReques…
6653314 
…t object with updated properties
@sebastianpiq
Remove unnecessary concat in the interceptors array
7ac84f4
@cotid-qualabs
update get query and headers function
3993e4b
@cotid-qualabs
reponse mode WIP
51086d7
@cotid-qualabs
response mode enabled keys
29eca78
@cotid-qualabs
include in request for response mode
bca18f7
@cotid-qualabs
settings update
d2b51cc
@cotid-qualabs
custom keys for response mode
6f45b1d
@cotid-qualabs
review changes
be7ec7b
@cotid-qualabs
cmcd report targets JSDocs
4d99b39
@cotid-qualabs
add current keys parameter to customKeys
cda45ea
@cotid-qualabs
fix constants
8b78a6b
@cotid-qualabs
fix JSDocs
7190088
@cotid-qualabs
fix default settingscmcd targets
f6772a3
@sebastianpiq
Add event mode listeners and state change handling in CmcdController
524b192
@sebastianpiq
Merge branch 'cmcdv2/response_mode' into cmcdv2/event-mode
aa52e03
@cotid-qualabs
Merge pull request #73 from qualabs/cmcdv2/response_mode
c88be65 
Cmcdv2/response mode
@sebastianpiq
Add event mode properties and initialize time interval in CmcdController
e4a141d
@cotid-qualabs
add response type
9e04959
@juanmanuel-qualabs
Merge branch 'cmcdv2/event-mode' into cmcdv2/critical-keys
c2ed749
juanmanuel-qualabs and others added 25 commits May 12, 2025 16:15
@juanmanuel-qualabs
[REFACTOR] Added 'keys' constants for each cmcd v2 mode
232cbd5
@juanmanuel-qualabs
Added code to log key verifications only once
2c62bdf
@juanmanuel-qualabs
Merge branch 'feature/cmcdv2' into cmcdv2/fix_available_keys_and_enabled
67e16d0
@juanmanuel-qualabs
Added logic to log included mandatory keys when not specified by user
9ed8cb5
@cotid-qualabs
Merge pull request #90 from qualabs/cmcdv2/fix_available_keys_and_ena…
3bc9d7a 
…bled

cmcdv2/Fix enabled and available keys for tagets settings
@cotid-qualabs
Merge pull request #92 from qualabs/cmcdv2/log_included_mandatory_keys
0487932 
cmcdv2/log included mandatory keys
@cotid-qualabs
cmcdv2/ time interval on event mode bugfix (#93)
288ee00
@cotid-qualabs
cmcdv2/bg key implementation (#94)
4268bb1 
* bg key implementation

* remove console log
@cotid-qualabs @juanmanuel-qualabs
cmcdv2/add warning for empty event array (#95)
cc29095 
* add warning for empty event array

* remove white space

* Update src/streaming/controllers/CmcdController.js

Co-authored-by: juanmanuel-qualabs <49200098+juanmanuel-qualabs@users.noreply.github.com>

---------

Co-authored-by: juanmanuel-qualabs <49200098+juanmanuel-qualabs@users.noreply.github.com>
@sebastianpiq
Fix cmcd constants descriptions (#96)
5d0aa73
@juanmanuel-qualabs
cmcdv2/cmcdrequest v2 to v1 (#97)
c83817c
@juanmanuel-qualabs
Cmcdv2/cmcd model refactor (#98)
e607e9c 
Refactor: Split CmcdController into CmcdModel & CmcdController
@juanmanuel-qualabs
Fixed isIncludedInRequestFilter reference in CmcdController (#99)
a1141dc
@cotid-qualabs
hotfixes for event mode after model refactor
65ea048
@juanmanuel-qualabs
Added check to return targetavailable keys if not inva
d2d57e9
@juanmanuel-qualabs
Fixed check for time interval definition
095386b
@cotid-qualabs
Merge pull request #100 from qualabs/hotfix/cmcdv2_fix_empty_enabledKeys
88dec22 
Added check to return targetavailable keys if not inva
@cotid-qualabs
Merge pull request #101 from qualabs/hotfix/cmcdv2_fix_time_interval_…
c8488f8 
…zero

hotfix/cmcdv2 fix time interval zero
@cotid-qualabs
Merge branch 'development' of github.com:qualabs/dash.js into feature…
23d5613 
…/cmcdv2
@cotid-qualabs
Add BSD License to CmcdModel
691041e
@cotid-qualabs
hotfix/cmcdv2 network interceptors sample page -config updates
14d5a77
@nicolaslevy
fixes in samples of cmcd v2
e15f63c
@cotid-qualabs
hotfix/enabledKeys undefined and enabledKeys empty
5eb5bc9
@cotid-qualabs
hotfix/Keys for each mode constants
8dcb29a
@juanmanuel-qualabs
Re added convertToCmcdV1 function from CML
e909cf1
@juanmanuel-qualabs juanmanuel-qualabs self-assigned this Jun 25, 2025
@cotid-qualabs cotid-qualabs force-pushed the feature/cmcdv2 branch 3 times, most recently from 042af7e to 7a9cff6 Compare January 14, 2026 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cotid-qualabs cotid-qualabs cotid-qualabs approved these changes

Assignees

@juanmanuel-qualabs juanmanuel-qualabs

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@juanmanuel-qualabs @cotid-qualabs @sebastianpiq @nicolaslevy