feat: CMCD v2 parameters

[cotid-qualabs]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @cotid-qualabs, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces comprehensive support for CMCD v2, focusing on enabling manifest-driven configuration of reporting targets. It adds new data structures and parsing logic to interpret CMCD v2 elements within DASH manifests, allowing for more dynamic and flexible control over how client-side media data is reported. The changes ensure that CMCD reporting can be tailored directly by content providers through the manifest, enhancing optimization capabilities.

Highlights

• CMCD v2 Implementation: Full implementation of CMCD v2 functionality, enabling advanced client-side data reporting capabilities.
• Manifest-Driven Reporting Targets: Introduction of ReportingTargets and EventTarget elements in DASH manifests, allowing CMCD reporting configurations to be defined directly within the manifest.
• New EventTarget Class: A dedicated EventTarget class is added to encapsulate the properties of each CMCD reporting destination, including URL, mode, keys, and events.
• Configuration Priority Update: CMCD configuration now prioritizes settings defined in the manifest over application-level settings for reporting targets, providing greater flexibility.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces support for CMCD v2 parameters, specifically EventTarget and ReportingTargets. It includes a new EventTarget class, updates DashConstants and DashParser to recognize these new elements, and modifies CMCDParameters to parse them from the manifest. Additionally, CmcdPropertyMap and CmcdConfigAccessor have been updated to correctly prioritize and retrieve CMCD v2 target-specific properties from both manifest and player settings. A new function getEventTargetsFromCmcdParameters has been added to CmcdModel to expose these targets.

[gemini-code-assist]

The getCmcdParametersFromManifest() function updates the cmcdConfig with manifest parameters and then returns the raw cmcdParametersFromManifest object. However, cmcdConfig is designed to handle priority-based resolution of properties (manifest > settings > default) using the CmcdPropertyMap. Directly accessing reportingTargets from the raw manifest parameters here bypasses this resolution logic.

To ensure consistency and leverage the CmcdConfigAccessor's capabilities, it would be better to retrieve the resolved reportingTargets using cmcdConfig.getTargets() which applies the full priority logic and version checks.

    function getEventTargetsFromCmcdParameters(){
        return cmcdConfig.getTargets();
    }

[gemini-code-assist]

The enabled property is initialized to true in the constructor. However, if data.enabled is undefined or null, assigning it directly will override the default true with undefined or null. It would be more robust to explicitly default to true if data.enabled is not provided or is null, or cast it to a boolean to ensure it's always a boolean value.

Suggested change

	this.enabled = data.enabled;
	this.enabled = data.enabled ?? true;