interconnect: core: ignore duplicate bw requests

[rlaggysh]

Ignore the icc_set_bw requests from the client if there is no change with respect to tag, avg_bw and peak_bw values from previous request.

[qswat-orbit-external]

Merge Check Failed: No CR Numbers Found

Error: No Change Request numbers were found.

Please add Change Request numbers to your pull request description in the format CRs-Fixed: 12345 or link GitHub issues that are associated with Change Requests.

[qlijarvis]

PR #876 — validate-patch

PR: #876

Verdict	Issues	Detailed Report
❌	0	Full report

Final Summary

1. Lore link present: No — no lore.kernel.org link found in commit message; no commit prefix present to indicate upstream status
2. Lore link matches PR commits: N/A — no lore link to compare against
3. Upstream patch status: Unknown — cannot determine without lore link or commit prefix; commit appears to be a new vendor change without upstream reference
4. PR present in qcom-next/topics: Partial - 1/1 commit(s) only have partial integration evidence

Verdict: ❌ — click to expand

🔍 Patch Validation

PR: #876 - interconnect: core: ignore duplicate bw requests
Upstream commit: N/A
Verdict: ❌ FAIL

Commit Message

Check	Status	Note
Subject matches upstream	N/A	No lore link present
Body preserves rationale	❌	Missing detailed rationale, no Fixes tag, no upstream reference
Fixes tag present/correct	❌	No Fixes tag present
Authorship preserved	N/A	No upstream source to compare
Backport note (if applicable)	N/A	Not a backport

Diff

File	Status	Notes
drivers/interconnect/core.c	⚠️	Functional change without upstream reference
drivers/interconnect/internal.h	⚠️	New field added without upstream reference

Issues

Critical Issues:

1. No lore.kernel.org link present — The commit message contains no Link: tag pointing to lore.kernel.org. According to the validate-patch skill Step 1, this is an immediate FAIL condition. The commit lacks any of the expected upstream reference patterns:

   • No Link: https://lore.kernel.org/...
   • No Patch-mainline: tag
   • No commit prefix (UPSTREAM:, FROMLIST:, BACKPORT:, QCLINUX:, PENDING:, WORKAROUND:)

2. Missing commit prefix — The subject line lacks a required prefix to indicate the patch's upstream status. Expected prefixes:

   • UPSTREAM: if merged into Linus's tree
   • FROMLIST: if posted to mailing list but not yet merged
   • BACKPORT: if backported with modifications
   • QCLINUX: if vendor-only (no upstream equivalent)
   • PENDING: if work-in-progress
   • WORKAROUND: if temporary fix

3. Insufficient commit message — The commit body is only one sentence and lacks:

   • Detailed problem description (why are duplicate requests problematic?)
   • Impact analysis (what breaks without this fix?)
   • Solution rationale (why this approach?)
   • Fixes: tag if this addresses a regression
   • Performance or behavioral justification

4. Integration presence is partial — According to integration_presence_report.md, this commit shows only "partial" evidence in qcom-next/topics. The report states: "subject or partial tree evidence found, but full change was not verified." This suggests the commit may be incomplete or differs from what's already in the integration branches.

5. Potential logic issue — The patch checks prev_tag == tag to skip duplicate requests, but prev_tag is only set in icc_set_tag(). If a client calls icc_set_bw() without first calling icc_set_tag(), prev_tag will be uninitialized (0), potentially causing incorrect behavior.

Verdict

Do not merge. This commit must be corrected before acceptance:

1. Add appropriate commit prefix (FROMLIST: if posted upstream, QCLINUX: if vendor-only)
2. If this is an upstream patch, add Link: https://lore.kernel.org/r/<message-id> tag
3. Expand commit message with problem statement, impact, and solution rationale
4. Add Fixes: tag if this addresses a regression
5. Verify the logic handles uninitialized prev_tag correctly
6. Reconcile with the partial integration presence in qcom-next/topics

Final Summary

1. Lore link present: No — no lore.kernel.org link found in commit message; no commit prefix present to indicate upstream status
2. Lore link matches PR commits: N/A — no lore link to compare against
3. Upstream patch status: Unknown — cannot determine without lore link or commit prefix; commit appears to be a new vendor change without upstream reference
4. PR present in qcom-next/topics: Partial — integration_presence_report.md shows "partial" status: "subject or partial tree evidence found, but full change was not verified" (0/1 fully present, 1/1 partial)

Deterministic Integration Presence

Integration Presence Report

This report is generated by Jarvis before validate-patch runs.
It is the authoritative source for whether PR changes are already present
in qcom-next or in the kernel topic branches.

Kernel repo: /local/mnt/workspace/sgaud/Qgenie/image_pipeline/kernel
qcom-next ref: 36229361f23e694eb897225a6a859064e11471c5
topics remote: topics -> https://github.com/qualcomm-linux/kernel-topics
topics fetch: fetched

Commit	Subject	qcom-next	topics	Final
1/1	[PATCH] interconnect: core: ignore duplicate bw requests	partial - subject or partial tree evidence found, but full change was not verified	partial - subject or partial tree evidence found, but full change was not verified	partial

Final Status

overall_status: PARTIAL
present_commits: 0/1
partial_commits: 1/1
missing_commits: 0/1
topics_checked_for_commits: 1/1
final_summary: PR present in qcom-next/topics: Partial - 1/1 commit(s) only have partial integration evidence

[qlijarvis]

PR #876 — checker-log-analyzer

PR: #876
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/30443113616

Checker	Result	Summary
Checker	Result	Summary
checkpatch	✅	No style issues
dt-binding-check	⏭️	No DT binding changes
dtb-check	⏭️	No devicetree changes
sparse-check	✅	No static analysis issues
check-uapi-headers	✅	No UAPI changes
check-patch-compliance	❌	Missing subject prefix
tag-check	❌	Missing required subject prefix

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #876 - interconnect: core: ignore duplicate bw requests
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/30443113616
Target branch: qcom-6.18.y

Checker	Result	Summary
checkpatch	✅	No style issues
dt-binding-check	⏭️	No DT binding changes
dtb-check	⏭️	No devicetree changes
sparse-check	✅	No static analysis issues
check-uapi-headers	✅	No UAPI changes
check-patch-compliance	❌	Missing subject prefix
tag-check	❌	Missing required subject prefix

---

❌ check-patch-compliance

Root cause: Commit subject does not start with a required prefix tag.

Failure details:

Checking commit: interconnect: core: ignore duplicate bw requests
Commit summary does not start with a required prefix

Analysis:
The commit subject "interconnect: core: ignore duplicate bw requests" has no prefix tag. The check-patch-compliance checker enforces that all commits must start with one of: FROMLIST:, FROMGIT:, UPSTREAM:, or BACKPORT:.

Fix:
Add an appropriate prefix to the commit subject based on the patch origin:

git rebase -i d9ebca924ccc   # mark commit as 'edit'
git commit --amend -m "FROMLIST: interconnect: core: ignore duplicate bw requests"
# (keep the rest of the commit message unchanged)
git rebase --continue

Choose the correct prefix:

• FROMLIST: — if posted to lore.kernel.org but not yet merged
• FROMGIT: — if taken from a maintainer git tree
• UPSTREAM: — if merged into Linus's mainline tree
• BACKPORT: — if backported with modifications
• QCLINUX: — if vendor-only (note: this will still fail check-patch-compliance but is acceptable for vendor-only changes)

Reproduce locally:

cd kernel
git log d9ebca924ccc..3688fc654a47 --format="%H %s"
# Verify the subject has no prefix

---

❌ tag-check

Root cause: Target branch qcom-6.18.y requires all commits to have a subject prefix, but this commit has none.

Failure details:
Commit 3688fc654a47 ("interconnect: core: ignore duplicate bw requests"): subject line does not start with a required prefix.

All branches except qcom-next and qcom-next-staging require one of:
FROMLIST: / FROMGIT: / UPSTREAM: / BACKPORT: / QCLINUX: / PENDING: / WORKAROUND:

Fix:
Same as check-patch-compliance above — add the appropriate prefix to the commit subject.

Reproduce locally:

git log d9ebca924ccc..3688fc654a47 --format="%H %s" | while read sha subject; do
  if ! echo "$subject" | grep -qE '^(FROMLIST|FROMGIT|UPSTREAM|BACKPORT|QCLINUX|PENDING|WORKAROUND):'; then
    echo "MISSING prefix: $sha $subject"
  fi
done

---

Verdict

1 blocker must be fixed before merge:
The commit subject must be amended to include a valid prefix tag (FROMLIST:, FROMGIT:, UPSTREAM:, BACKPORT:, QCLINUX:, PENDING:, or WORKAROUND:). This is a mandatory requirement for all commits targeting branches other than qcom-next or qcom-next-staging.

Once the prefix is added, re-push the PR to trigger a new CI run. All other checkers passed successfully.