AudioRecord: skip when no real capture source is available#465
Merged
Conversation
Avoid running PipeWire mic recording through an implicit default source when no concrete PipeWire source was discovered. On systems without a real capture source, this path can fall through to dummy/null/default behavior or fail after producing an empty recording. Reuse the existing ALSA capture profile probe before recording. If a real ALSA capture path is available, switch to direct ALSA capture. If no real capture path exists, report SKIP instead of failing the test. Also replace the direct wpctl set-default call with the existing bounded pw_set_default_source helper. Signed-off-by: Srikanth Muppandam <smuppand@qti.qualcomm.com>
ricardosalveti
approved these changes
May 30, 2026
bhargav0610
approved these changes
Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update AudioRecord to avoid running PipeWire mic recording through an implicit default source when no concrete PipeWire capture source is discovered.
The previous flow allowed --source mic to continue with backend=pipewire even when SRC_ID was empty. In that case, the test attempted pw-record against the default source and then fell back to arecord -D pipewire. On systems with no real capture source, this can lead to empty recordings and false CI failures. This fixes the issue on qualcomm-linux/meta-qcom#2127
Why
Some platforms may boot with PipeWire/WirePlumber running but without a real audio capture source exposed. In that case, recording from an implicit PipeWire default source is not a valid mic capture test.
The updated behavior makes the test capability-aware:
This avoids treating missing capture hardware or missing capture exposure as a PipeWire recording regression.