shmbridge: avoid false failures from qcom_scm kernel cmdline#467
Merged
Conversation
The shmbridge test scans current-boot kernel logs for qcom_scm-related errors. The existing match is too broad and can treat benign boot arguments such as qcom_scm.download_mode=1 as failures when other kernel command line parameters contain error-like words such as panic. Update the log scan to: - collect qcom_scm/shmbridge-related lines - ignore Kernel command line entries - ignore qcom_scm.download_mode - ignore CONFIG_QCOM_SCM references - fail only when the remaining lines contain real error keywords This avoids false LAVA failures while preserving detection of genuine qcom_scm or shmbridge errors. Signed-off-by: Srikanth Muppandam <smuppand@qti.qualcomm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The shmbridge test scans current-boot kernel logs for qcom_scm-related errors. The existing match is too broad and can treat benign boot arguments such as qcom_scm.download_mode=1 as failures when other kernel command line parameters contain error-like words such as panic.
Update the log scan to:
This avoids false LAVA failures while preserving detection of genuine qcom_scm or shmbridge errors.