EFI_Variable_Validation: improve OsTrialBootStatus write diagnostics#476
Open
smuppand wants to merge 1 commit into
Open
EFI_Variable_Validation: improve OsTrialBootStatus write diagnostics#476smuppand wants to merge 1 commit into
smuppand wants to merge 1 commit into
Conversation
OsTrialBootStatus is the platform validation target for this test, so keep the mandatory EFI variable write/read validation on that variable instead of replacing it with a generic test-owned variable. Fix the efivar -l count parsing to avoid multiline values causing integer comparison errors. Also improve diagnostics around the OsTrialBootStatus write path by logging the existing variable state, efivarfs mount state, efivarfs attributes when available, and recent EFI/efivar kernel messages when the write fails. This keeps the test aligned with the intended platform validation goal while making EFI variable write failures easier to debug in CI. Signed-off-by: Srikanth Muppandam <smuppand@qti.qualcomm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update
EFI_Variable_Validationto keepOsTrialBootStatusas the mandatory EFI variable validation target while improving parsing and failure diagnostics.The validation goal remains unchanged: verify EFI runtime/efivarfs support and validate write/read behavior for
OsTrialBootStatus.Keep
OsTrialBootStatusas the mandatory write/read validation variable.Fix
efivar -lcount parsing to avoid integer comparison errors such as: