send-to-lava: protect LAVA signals from printk corruption#478
Open
smuppand wants to merge 1 commit into
Open
Conversation
Kernel printk messages can be interleaved into userspace stdout on noisy systems and corrupt LAVA TESTCASE signal lines. This can cause LAVA to miss or misparse otherwise valid test results. Update send-to-lava.sh to validate and buffer result-file entries before emitting signals, sanitize testcase IDs, and briefly lower the kernel console loglevel only around the individual LAVA signal printf when /proc/sys/kernel/printk is writable. The original printk settings are saved and restored immediately after each signal line. Signed-off-by: Srikanth Muppandam <smuppand@qti.qualcomm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update
[send-to-lava.sh](http://send-to-lava.sh/)to make LAVA testcase signal emission more robust on noisy serial consoles.Kernel printk messages can be interleaved into userspace stdout and corrupt LAVA protocol lines, causing valid test results to be missed or misparsed by LAVA. This change protects only the tiny signal emission critical section without suppressing kernel logs during test execution.
Why
On some platforms, asynchronous kernel printk output can be injected into the middle of a LAVA signal line, for example: