Update source changes till 01/06/2026#9
Merged
Merged
Conversation
- Recorder client accessed fds[1] unconditionally when service sent only 1 fd. - Non-gbm allocator always sends ion_meta_fd as -1 - fd received by ion_meta_fd is 1 due to out of bound case of fds_ vector. - During deletevideotrack this invalid ion_meta_fd was closed, which resulted in closing fd 1. In all linux processes by default fd 0, 1,2 are reserved for stdin,stdout,stderr respectively. Signed-off-by: Shubhankar Kulkarni <shukulk@qti.qualcomm.com> Signed-off-by: Girish K <girik@qti.qualcomm.com>
- In QLI 2.0 and mainline builds, multiple OpenCL implementations are present(ICD loader, Qualcomm Adreno, and Rusticl).The ICD loader selects vendor libraries in a non-deterministic order, causing inconsistent platform/device indexing. - Exporting: OCL_ICD_FILENAMES=/usr/lib/libOpenCL_adreno.so.1 forces the ICD loader to prioritize the Qualcomm OpenCL implementation,ensuring consistent behavior across builds. Removed LD_LIBRARY_PATH which is not used. - Note: Issue does not exist in QLI 1.0 (single vendor, hardcoded loading). Signed-off-by: Jai Shiv <jshiv@qti.qualcomm.com> Signed-off-by: Girish K <girik@qti.qualcomm.com>
This reverts commit 9c483673f9d78e8cbe4084e4bf3c0803818f6359. Reason for revert: <CAMX headers are available now> Signed-off-by: Girish K <girik@qti.qualcomm.com>
- On the non-binder path, client connection is split into two phases: Phase 1 (RECORDER_CONNECT) - allocates client ID, adds to death_notifier_list_ Phase 2 (CALLBACK_SOCKET_READY) - sets up callback, adds to remote_cb_list_ - GetUniqueClientID() was only checking remote_cb_list_ to determine if an ID was free. Since remote_cb_list_ is not populated until Phase 2, a second client connecting immediately after the first (before Phase 2 completes) would see an empty remote_cb_list_ and get assigned the same client ID, causing duplicates. - Fix: use active_client_ids_ as the single source of truth for ID reservation. Signed-off-by: Jai Shiv <jshiv@qti.qualcomm.com> Signed-off-by: Girish K <girik@qti.qualcomm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here are the gerrits source code gerrit merged.