Skip to content

QTAC windows installer for open source release under Testing - #61

Open
Arkojit Sen (arko816) wants to merge 15 commits into
qualcomm:developfrom
arko816:feature-patch/windows-installer
Open

QTAC windows installer for open source release under Testing#61
Arkojit Sen (arko816) wants to merge 15 commits into
qualcomm:developfrom
arko816:feature-patch/windows-installer

Conversation

@arko816

Copy link
Copy Markdown
Contributor

Pull Request

Description
QTAC windows installer for open source release

Related Issue

Type of Change
Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Additional Context
Add any other context or screenshots about the pull request here.

Signed-off-by: Arkojit Sen <91142102+arko816@users.noreply.github.com>
run: .\packaging\windows\build-installer.ps1 -Arch x64

- name: Upload installer artifact
uses: actions/upload-artifact@v4
run: .\packaging\windows\build-installer.ps1 -Arch arm64

- name: Upload installer artifact
uses: actions/upload-artifact@v4
Comment thread .github/workflows/build.yml Outdated
shell: cmd
run: build.bat

- name: Regenerate devicelist.json with installed-path configPath entries

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick: Consider minifying this text

@Biswajee

Copy link
Copy Markdown
Member

Arkojit Sen (@arko816) , please review following comments:

  1. Whether QTAC examples are being shipped
  2. Whether QTAC interfaces are being shipped
  3. Please note that C# inter-op is required to be built & placed in Program Files. Required by C# example script.

Please sign upcoming commits before shipping to open-source.

Comment thread .github/workflows/build.yml Fixed
Comment thread .github/workflows/build.yml Fixed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants