[verifier] Use simplify in addition to minimal_polynomial in SymPy and fix input format for Rational#223
Merged
xumingkuan merged 2 commits intomasterfrom Oct 20, 2025
Merged
Conversation
xumingkuan
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #221
Sometimes SymPy doesn't like
sympy.minimal_polynomialfor expressions withsinandcos. It's still faster thansympy.simplify, so I added try-except clauses.Also fixes the input format for
Rationalto filter out the"at the beginning and the end of a number.