[optimizer] Allow calling optimizer with USE_RATIONAL=false using ECC set generated with USE_RATIONAL=true#225
Merged
xumingkuan merged 3 commits intomasterfrom Nov 7, 2025
Merged
Conversation
… set generated with USE_RATIONAL=true
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this PR, Quartz hangs when loading an ECC set with random parameters being rational numbers but USE_RATIONAL=false. This causes some inconvenience because we would have to manually convert the rational numbers into floating-point numbers in the first line of the ECC sets generated using USE_RATIONAL=true.
Now we can use Quartz with USE_RATIONAL=false (comment out the line in CMakeLists.txt) with any ECC set to get rid of the warnings when we don't need the rational number feature.