[Bug] [Parser] Let loading QASM files into Graph use ParamParser#227
Merged
xumingkuan merged 5 commits intomasterfrom Nov 14, 2025
Merged
[Bug] [Parser] Let loading QASM files into Graph use ParamParser#227xumingkuan merged 5 commits intomasterfrom
xumingkuan merged 5 commits intomasterfrom
Conversation
xumingkuan
added a commit
to aidan-wagner/qalm
that referenced
this pull request
Nov 14, 2025
…ntum-compiler#227) (#2) * [Bug] [Parser] Let loading QASM files into Graph use ParamParser * Set use_symbolic_pi to false * typo * typo * code format
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #226
This PR fast-forwards the implementation of loading QASM files into
Graphto the implementation of loading QASM files intoCircuitSeq. There are still a few differences:Graph.Graph, for example, the following is 3 gates inGraphbut 1 gate inCircuitSeq.CircuitSeq, it is still allowed inGraph.This PR also changes the behavior of
Graph::to_qasm(). Previously, all parameters were printed in the formatpi*0.xxxxxx; now the behavior is:USE_RATIONALis turned off, when the parameter is a multiple ofpi/4, then it will be printed in the formatpi*0.xxxxxx; otherwise, it will be printed as a floating-point number directly.USE_RATIONALis turned on, all parameters are printed in the formatpi*a/b, whereaandbare integers. Please beware thatacan be negative -- there will be cases likepi*-1/4.