fix #1 - sanitize alias targets for file system compatibility#2
Open
MrVauxs wants to merge 4 commits into
Open
fix #1 - sanitize alias targets for file system compatibility#2MrVauxs wants to merge 4 commits into
MrVauxs wants to merge 4 commits into
Conversation
Introduces `sanitizeFilename` to replace invalid characters (like `<`, `>`, `:`, `"`, `/`, `\`, `|`, `?`, `*`) with hyphens and truncate long filenames. This prevents errors when generating redirect files for aliases that contain characters incompatible with certain file systems (e.g., Windows).
…5c3-083b5219c980 fix(emitter): sanitize aliases with illegal filesystem characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1, LGTM and confirmed it manually on a real life repo that I am migrating from Quartz 4.
Introduces
sanitizeFilenameto replace invalid characters (like<,>,:,",/,\,|,?,*) with hyphens and truncate long filenames. This prevents errors when generating redirect files for aliases that contain characters incompatible with certain file systems (e.g., Windows).