Use signInWithPopup everywhere, drop signInWithRedirect#68
Merged
Conversation
signInWithRedirect in Firebase v10+ fails silently when third-party cookies are blocked (most modern browsers). getRedirectResult returns null after the OAuth round-trip, losing the authenticated user. Switch to signInWithPopup for both dev and prod — the earlier SW fix (navigateFallbackDenylist) ensures the popup opens the Firebase auth handler correctly instead of the SPA.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
signInWithRedirect/getRedirectResult— Firebase v10+ redirect flow fails silently when third-party cookies are blocked (most modern browsers), causinggetRedirectResultto return null after the OAuth round-tripsignInWithPopupfor both dev and production environmentsnavigateFallbackDenylist) ensures the popup opens the Firebase auth handler correctlyTest plan