Add append as a keyword argument to save#64
Open
pearlzli wants to merge 2 commits intoqueryverse:masterfrom
Open
Add append as a keyword argument to save#64pearlzli wants to merge 2 commits intoqueryverse:masterfrom
pearlzli wants to merge 2 commits intoqueryverse:masterfrom
Conversation
Author
|
@davidanthoff That was exactly it, thank you! I feel a little silly now... |
pearlzli
changed the title
Author
|
Hi @davidanthoff - have you had the chance to look at this at all? Thanks again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This currently fails thesavestreamingtest in a way that I can't make any sense of: I get aMethodError: no method matching -(::String, ::String)thrown byFileIO.savestreaming. Does anyone have any ideas?Fixed, and now all tests pass (9/29)
Also, I've chosen not to try to implement appending to a gzipped CSV.
Thanks in advance for your help! I'm pretty new to how things work in this package...