Merged
Conversation
Contributor
Author
|
Should we
|
Member
|
@the-thing thank you. |
Contributor
Author
|
These messages are not FIX messages - different queue. The messages affected are related to SSL handshake etc. |
Member
|
Yes, I understood that. :) thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix lingering message in SSL filter.
Changes
lingerflag set to true for initiator and acceptororg.apache.mina.filter.ssl.SslFilter#onClosesupportslingerparameter that writes any queued messages before closing.https://github.com/apache/mina/blob/9e45469b747d9d77de754ba1bc7c9bf0d4d67b89/mina-core/src/main/java/org/apache/mina/filter/ssl/SslFilter.java#L337
This fixes last handshake message described in #1166 but it will also flush any other messages that are queued which is probably desired. With this change -
quickfix.mina.HttpProxyTest#shouldLoginBasicAuthWithSsldoesn't throw the exception (make sure that debug logging works to see before and after change).