Draft
Conversation
saghul
force-pushed
the
explicit-resource-management
branch
from
a8b475d to
42bc792
Compare
Co-authored-by: Ben Noordhuis <info@bnoordhuis.nl> Closes: #865
saghul
force-pushed
the
explicit-resource-management
branch
from
42bc792 to
4fdbe0e
Compare
bnoordhuis
reviewed
Apr 25, 2026
Contributor
bnoordhuis
left a comment
bnoordhuis
left a comment
There was a problem hiding this comment.
+1700 lines is more than I have time to review in-depth at the moment. I'll trust your good judgement.
| Otherwise looks up Symbol.asyncDispose (with Symbol.dispose fallback | ||
| when u8=1) or Symbol.dispose (u8=0) and throws TypeError if missing | ||
| or non-callable. Stack: value -> value, method. */ | ||
| DEF( using_check, 2, 1, 2, u8) |
Contributor
There was a problem hiding this comment.
AI comments, right? I'd remove them and just let the code do the talking (in general, not just here; I already spot several in quickjs.c)
Rule of thumb: comment why, not what, and only when the why is not obvious when looking at the code itself.
Contributor
Author
There was a problem hiding this comment.
Yep, and sure thing, I opened as draft do a few more passes on it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Co-authored-by: Ben Noordhuis info@bnoordhuis.nl
Closes: #865