Skip to content

NPM release workflow#12

Merged
johnpmitsch merged 2 commits into
mainfrom
npm_release
Apr 21, 2026
Merged

NPM release workflow#12
johnpmitsch merged 2 commits into
mainfrom
npm_release

Conversation

@johnpmitsch

@johnpmitsch johnpmitsch commented Apr 21, 2026

Copy link
Copy Markdown
Collaborator

Note

Medium Risk
Changes the release trigger and adds a new npm publishing workflow, which can affect artifact generation and package publishing if tags/releases or required binaries are misconfigured.

Overview
Adds a new GitHub Actions workflow (publish-npm.yml) to manually publish @quicknode/sdk (main package + per-platform napi subpackages) by downloading .node binaries from a specified GitHub release tag, verifying required platforms, running napi prepublish, and publishing to npm using an NPM_TOKEN.

Updates the existing release.yml workflow to trigger on GitHub release publish (instead of tag push) and to attach CI-built artifacts to the published release via tag_name: ${{ github.event.release.tag_name }}. Also renames the Node package from @quicknode/sdk-next to @quicknode/sdk, adds the macOS arm64 target to the napi target list, updates the browser shim error message, and documents the new npm release flow in README.md.

Reviewed by Cursor Bugbot for commit d703a2d. Bugbot is set up for automated code reviews on this repo. Configure here.

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit c969fd8. Configure here.

Comment thread .github/workflows/publish-npm.yml Outdated
@johnpmitsch johnpmitsch merged commit 917343f into main Apr 21, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant