-
Notifications
You must be signed in to change notification settings - Fork 0
Pypi #13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Pypi #13
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,62 @@ | ||
| name: Publish PyPI | ||
|
|
||
| on: | ||
| workflow_dispatch: | ||
| inputs: | ||
| tag: | ||
| description: 'Git tag to publish (e.g. v0.1.0-alpha.5)' | ||
| required: true | ||
|
|
||
| jobs: | ||
| publish: | ||
| runs-on: ubuntu-latest | ||
| permissions: | ||
| contents: read | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| with: | ||
| ref: refs/tags/${{ inputs.tag }} | ||
|
|
||
| - uses: actions/setup-python@v5 | ||
| with: | ||
| python-version: '3.12' | ||
|
|
||
| - name: Install twine | ||
| run: pip install "twine>=5,<6" | ||
|
|
||
| - name: Download Python artifacts from GitHub release | ||
| run: | | ||
| mkdir -p dist | ||
| gh release download "${{ inputs.tag }}" \ | ||
| --pattern 'quicknode_sdk-*.whl' \ | ||
| --dir dist | ||
| gh release download "${{ inputs.tag }}" \ | ||
| --pattern 'quicknode_sdk-*.tar.gz' \ | ||
| --dir dist | ||
| env: | ||
| GH_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
|
|
||
| - name: Verify required wheels + sdist are present | ||
| run: | | ||
| wheel_count=$(ls dist/quicknode_sdk-*.whl 2>/dev/null | wc -l) | ||
| sdist_count=$(ls dist/quicknode_sdk-*.tar.gz 2>/dev/null | wc -l) | ||
| echo "Found $wheel_count wheels and $sdist_count sdist(s)" | ||
| if [ "$wheel_count" -ne 16 ]; then | ||
| echo "Expected 16 wheels (4 python versions × 4 linux targets), got $wheel_count" | ||
| ls -la dist/ | ||
| exit 1 | ||
| fi | ||
| if [ "$sdist_count" -ne 1 ]; then | ||
| echo "Expected 1 sdist, got $sdist_count" | ||
| ls -la dist/ | ||
| exit 1 | ||
| fi | ||
|
|
||
| - name: Check distributions with twine | ||
| run: twine check dist/* | ||
|
|
||
| - name: Publish to PyPI | ||
| env: | ||
| TWINE_USERNAME: __token__ | ||
| TWINE_PASSWORD: ${{ secrets.PYPI_API_TOKEN }} | ||
| run: twine upload --non-interactive dist/* | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,5 @@ | ||
| [project] | ||
| name = "sdk" | ||
| name = "quicknode-sdk" | ||
|
|
||
| [tool.maturin] | ||
| module-name = "sdk._core" | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Script injection via unsanitized workflow input in shell
High Severity
${{ inputs.tag }}is directly interpolated into shellruncommands, which is a well-known GitHub Actions script injection vulnerability. A user with write access could supply a crafted tag value (e.g., containing"; malicious-command #) that breaks out of the double quotes and executes arbitrary commands. Since this job later runstwine uploadwith access toPYPI_API_TOKEN, injected code could tamper with thedist/contents before upload, enabling a supply chain attack on PyPI. The safe fix is to pass the input via an environment variable (env: TAG: ${{ inputs.tag }}) and reference"$TAG"in the shell.Reviewed by Cursor Bugbot for commit 16ac47f. Configure here.