Dx 5046 remove jsonparse from ruby gem and add RBS#16
Merged
johnpmitsch merged 18 commits intoApr 27, 2026
Merged
Conversation
…lisions Hashie::Mash exposes fields as methods, which collides with built-ins like Hash#chain (Enumerable) and Hash#methods (Kernel) — emitting noisy warnings on every API field with that name and silently returning the wrong value under dot-notation. Replaced with a Hash subclass using Hashie::Extensions::IndifferentAccess. Symbol- and string-key access still work; dot-notation is gone. Examples and docs updated to use symbol keys as the primary access style.
johnpmitsch
changed the title
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 652a6f5. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Medium Risk
Ruby’s public API shape changes from JSON-string responses to native
Hash/Array(with indifferent access) and introduces a new Ruby wrapper layer, which may break existing callers relying onJSON.parseor exact return types.Overview
Ruby binding now returns native Ruby values instead of JSON strings by serializing Rust responses via
serde_magnus, and moves the Magnus-exposed classes underQuicknodeSdk::Native::*.Adds a pure-Ruby wrapper layer (
QuicknodeSdk::SDKplus per-client delegators) that forwards calls to the native clients while supporting bare/kwargs/positional-hash call styles and wrapping returned hashes inQuicknodeSdk::IndifferentHashfor symbol/string key access.Updates documentation and Ruby examples to remove
JSON.parse, addshashieas a runtime dependency, expands gem packaging to include the new Ruby files and signatures, and introduces manually maintained RBS typings plus Solargraph/Steep config for editor/LSP support.Reviewed by Cursor Bugbot for commit 920623a. Bugbot is set up for automated code reviews on this repo. Configure here.