Ci#2
Conversation
| serde = { version = "1.0", features = ["derive"] } | ||
| serde_json = "1.0" | ||
| reqwest = { version = "0.13.2", features = ["json", "query"] } | ||
| reqwest = { version = "0.13.2", default-features = false, features = ["json", "query", "rustls", "http2"] } |
There was a problem hiding this comment.
Dropped system-proxy feature disables proxy environment variable support
Medium Severity
Switching reqwest to default-features = false drops the system-proxy default feature (alongside charset). The developer re-added rustls and http2 explicitly but missed system-proxy, which enables reading HTTP_PROXY/HTTPS_PROXY/NO_PROXY environment variables via hyper-util. The SDK's HTTP client will now silently ignore system proxy configuration, breaking usage in corporate or proxy-dependent environments.
Reviewed by Cursor Bugbot for commit 977dced. Configure here.
…ser shim to npm package
…napi build" This reverts commit 778c6b6.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
There are 2 total unresolved issues (including 1 from previous review).
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 3887d1f. Configure here.


Note
Medium Risk
Release automation and packaging changes can break publishing/consumption across ecosystems, and the
reqwestTLS backend change (rustls, no default features) may affect runtime connectivity in subtle ways.Overview
Adds a tag-triggered GitHub Actions
Releaseworkflow that builds and uploads artifacts for the Rust crate, Python wheels/sdist (viamaturin+ Zig cross), Node native modules (napi-rs + optional Zig cross, symbol stripping), and Ruby gems (including cross-compiled.so+ platform gem), then publishes a GitHub Release with the collected artifacts.Updates packaging metadata and release ergonomics: adds a
just release <version>task to bump versions across Rust/Python/npm/Ruby and tag a release, renames the npm package to@quicknode/sdk-nextwith an explicitexportsmap, ESM wrapper (sdk.mjs), and browser shim, and adds a minimalquicknode_sdk.gemspecfor Ruby. Also tweaks the generated TS types (Webhook.updatedAtbecomes optional) and switchessdk-core’sreqwesttorustls/http2withdefault-features = false(and adds crate metadata likerepository, keywords, categories).Reviewed by Cursor Bugbot for commit 35408e1. Bugbot is set up for automated code reviews on this repo. Configure here.