Skip to content

Ci#2

Merged
johnpmitsch merged 28 commits into
mainfrom
CI
Apr 16, 2026
Merged

Ci#2
johnpmitsch merged 28 commits into
mainfrom
CI

Conversation

@johnpmitsch

@johnpmitsch johnpmitsch commented Apr 16, 2026

Copy link
Copy Markdown
Collaborator

Note

Medium Risk
Release automation and packaging changes can break publishing/consumption across ecosystems, and the reqwest TLS backend change (rustls, no default features) may affect runtime connectivity in subtle ways.

Overview
Adds a tag-triggered GitHub Actions Release workflow that builds and uploads artifacts for the Rust crate, Python wheels/sdist (via maturin + Zig cross), Node native modules (napi-rs + optional Zig cross, symbol stripping), and Ruby gems (including cross-compiled .so + platform gem), then publishes a GitHub Release with the collected artifacts.

Updates packaging metadata and release ergonomics: adds a just release <version> task to bump versions across Rust/Python/npm/Ruby and tag a release, renames the npm package to @quicknode/sdk-next with an explicit exports map, ESM wrapper (sdk.mjs), and browser shim, and adds a minimal quicknode_sdk.gemspec for Ruby. Also tweaks the generated TS types (Webhook.updatedAt becomes optional) and switches sdk-core’s reqwest to rustls/http2 with default-features = false (and adds crate metadata like repository, keywords, categories).

Reviewed by Cursor Bugbot for commit 35408e1. Bugbot is set up for automated code reviews on this repo. Configure here.

Comment thread crates/core/Cargo.toml
serde = { version = "1.0", features = ["derive"] }
serde_json = "1.0"
reqwest = { version = "0.13.2", features = ["json", "query"] }
reqwest = { version = "0.13.2", default-features = false, features = ["json", "query", "rustls", "http2"] }

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dropped system-proxy feature disables proxy environment variable support

Medium Severity

Switching reqwest to default-features = false drops the system-proxy default feature (alongside charset). The developer re-added rustls and http2 explicitly but missed system-proxy, which enables reading HTTP_PROXY/HTTPS_PROXY/NO_PROXY environment variables via hyper-util. The SDK's HTTP client will now silently ignore system proxy configuration, breaking usage in corporate or proxy-dependent environments.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 977dced. Configure here.

Comment thread .github/workflows/release.yml
Comment thread .github/workflows/release.yml
Comment thread Justfile Outdated

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

There are 2 total unresolved issues (including 1 from previous review).

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 3887d1f. Configure here.

Comment thread Justfile
@johnpmitsch johnpmitsch merged commit 7f81f88 into main Apr 16, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant