core/window: add parentWindow property to FloatingWindow#378
Open
bbedward wants to merge 3 commits intoquickshell-mirror:masterfrom
Open
core/window: add parentWindow property to FloatingWindow#378bbedward wants to merge 3 commits intoquickshell-mirror:masterfrom
bbedward wants to merge 3 commits intoquickshell-mirror:masterfrom
Conversation
outfoxxed
requested changes
Nov 26, 2025
e6bcba1 to
7d989bd
Compare
7d989bd to
f166604
Compare
Member
|
Looks good except this case which does not work FloatingWindow {
id: w
FloatingWindow {
parentWindow: w
visible: true
}
}if initially invisible and later made visible it works as expected |
f166604 to
86dae5d
Compare
Contributor
Author
I changed to hook into visibility and that case is now fixed |
outfoxxed
requested changes
Dec 23, 2025
08c7fc2 to
bcc3d42
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows setting a parentWindow for FloatingWindow , which on wayland calls xdg_toplevel::set_parent .
Compositors may handle child windows differently (e.g. a dialog), by opening them as floating / positioned within the window that triggered them. This allows creating windows with that behavior.