services/pipewire: make ENOENT non-fatal#490
Open
marcusramberg wants to merge 1 commit intoquickshell-mirror:masterfrom
Open
services/pipewire: make ENOENT non-fatal#490marcusramberg wants to merge 1 commit intoquickshell-mirror:masterfrom
marcusramberg wants to merge 1 commit intoquickshell-mirror:masterfrom
Conversation
Member
|
Is there any determination for why we're excluding enoent in particular apart from it being the one that was failing? Pipewire error codes seemed to just come from the underlying syscalls instead of being distinct for any particular type of error. |
1ded080 to
04ac53c
Compare
Author
|
My thinking was that ENOENT seemed to indicate some missing device and probably wasn't fatal, but I don't have any deep insights in pipewire so I'm totally willing to accept it might not be the right fix. |
04ac53c to
821ee37
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #486 as it only logs a warning on startup. DMS input/output selector works as normal.