network: add freebsd backend#500
Open
charlesrocket wants to merge 2 commits intoquickshell-mirror:masterfrom
Open
network: add freebsd backend#500charlesrocket wants to merge 2 commits intoquickshell-mirror:masterfrom
charlesrocket wants to merge 2 commits intoquickshell-mirror:masterfrom
Conversation
charlesrocket
force-pushed
the
fbsd-network
branch
10 times, most recently
from
59ccfa6 to
e13d1b8
Compare
charlesrocket
force-pushed
the
fbsd-network
branch
from
e13d1b8 to
8bd0785
Compare
Contributor
|
Is there a reason to use wpa_cli instead of the control interface directly? wpa_supplicant is a valid backend for linux as well. Is there other networking stacks for FreeBSD? If so, this should probably be the FreeBSD impl of the wpa_supplicant backend and not the other way around. I was planning on adding IWD as a backend eventually, which is a similar problem. I think that these backends should cover only the portion of the API they can support alone. For example, the Linux IWD backend wouldn't use udev to list non-wireless devices. |
Author
|
I used CLI because I am familiar with it. Right now I just want the current FBSD PRs merged, then I can start improving these modules. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a native FreeBSD backend for the network module. Tested with
network.qml/widget.Requires a fix from #474 (085f646) for successful builds.