core: improve named icon detection#532
core: improve named icon detection#532charlesrocket wants to merge 1 commit intoquickshell-mirror:masterfrom
Conversation
b1baed0 to
75cfd3c
Compare
75cfd3c to
5f92890
Compare
|
This is generally supposed to be handled by qt, and the qpa selecting light or dark icons. |
|
Pulling the GTK preference would probably require a hardcoded path to config, not sure if I can reach it via Qt API. |
|
This shouldnt require checking the gtk theme. If the user configured Qt properly, then the information should be available from the QPA. |
|
You mean GNOME settings to KDE settings configuration? |
|
No. Most features of Quickshell don't even work under GNOME since they don't implement the protocols necessary for it, and I'm not aware of anyone using it under KDE, as plasmashell has much better insight into the DE. I'm talking about standalone QPA themes such as qtengine and qt(5/6)ct, or KDE's QPA, which are supposed to back Qt's icon theme loading, including color selection. For example my icon theme is "breeze-dark" set by qtengine. |
|
Oh I see, I'll check it out. |
This fixes weak named icon detection. The provider now can look for light or dark icons depending on the system settings (KDE/GTK).
Valid paths (that were undetectable before):
Now the provider will pull the icon from
breeze-darkif dark icons are preferred.Tested on FreeBSD via
transmission-gtk/transmission-qt.