Crash fix: Sometimes output can be nullptr such as when it is a placeholder#578
Open
bryanparadis wants to merge 2 commits intoquickshell-mirror:masterfrom
Open
Crash fix: Sometimes output can be nullptr such as when it is a placeholder#578bryanparadis wants to merge 2 commits intoquickshell-mirror:masterfrom
bryanparadis wants to merge 2 commits intoquickshell-mirror:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am using Niri and Noctalia-Shell. Was running into an issue that sometimes when my monitor was off Noctalia-Shell would crash. I can easily reproduce the issue by quickly replugging my hdmi on the monitor side 5-10 times. Below is an example stacktrace. Note that also in the same state once quickshell itself stops crashing any launched process will crash in qt for the same reason. I put a patch in for that in qtbase here. Additional context in noctalia-dev/noctalia-shell#1822.