Conversation
|
@noracato do the changes to |
louispt1
left a comment
There was a problem hiding this comment.
Works well for me locally and seems reasonable!
I'm a bit unsure about the haml override - seems like something that might be an issue in the future but also not sure what we can do about it in the short term - maybe @noracato has ideas.
| default: &default | ||
| source_path: app/javascript | ||
| source_entry_path: packs | ||
| javascript_transpiler: babel |
There was a problem hiding this comment.
Babel was the default javascript_transpiler before the bump but now it changed, so if we do not specify it it will use the new default (which is SWC). Their reason for the chance is because SWC is much faster so is not a trivial decision. For SWC we will need to install new dependencies and make sure nothing breaks if we remove that config, is all explained here.
There was a problem hiding this comment.
Ok seems out of scope for this PR then, interesting though!
Description
Bumped shakapacker in 3 stages:
Stage 1: 6.0 to 7.2.3 (v7 upgrade guide)
Stage 2: 7.2.3 to 8.4 (v8 upgrade guide)
Stage 3: 8.4 to 9.5 (v9 upgrade guide)
Type of change
Checklist
Related Issues
Closes #4644