Optionally add close shortcuts to dialogs#71
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Helps address qupath/qupath#2107
This changes
FXUtils.addCloseWindowShortcuts(Stage)to becomeFXUtils.addCloseWindowShortcuts(Window)so that it's more general.But it's still not general enough for a
Dialog, since this isn't a subclass ofWindoweither. So it addsFXUtils.addCloseDialogShortcuts(DialogPane)as well.Dialog.Builderis then updated to have acloseShortcuts(boolean addShortcuts)method so that it's possible to specify that the shortcuts are or are not added.The impact is mostly for
Ctrl+WorCmd+W, sinceEscalready seems to work.If the shortcuts aren't specified, they are added by default for all dialogs that have no buttons, or that have a single button that is
OK,CancelorClose.The behavior is to press the
Cancelbutton is present, or fire a window close request otherwise.