Make all accesses implement ArrayDataAccess#20
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change all
DataAccessby making them implementArrayDataAccess.Before this PR, when a tile of an image was accessed for the first time, the corresponding
BufferedImage(orRaster) was saved, and getting a pixel of this tile was fetching the pixel from theBufferedImage/Raster.With this PR, when a tile of an image is accessed for the first time, an array is created and populated by all pixels of the corresponding
BufferedImage/Raster. Getting a pixel of this tile is now simply an array access.In terms of performance, with this PR, the first access to a pixel belonging to a tile is slower, but all subsequent access to pixels of the same tile are faster.