Open
Conversation
Bumps [@angular/compiler](https://github.com/angular/angular/tree/HEAD/packages/compiler) from 21.0.6 to 21.0.7. - [Release notes](https://github.com/angular/angular/releases) - [Changelog](https://github.com/angular/angular/blob/main/CHANGELOG.md) - [Commits](https://github.com/angular/angular/commits/v21.0.7/packages/compiler) --- updated-dependencies: - dependency-name: "@angular/compiler" dependency-version: 21.0.7 dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps and [minimatch](https://github.com/isaacs/minimatch). These dependencies needed to be updated together. Updates `minimatch` from 10.1.1 to 10.2.4 - [Changelog](https://github.com/isaacs/minimatch/blob/main/changelog.md) - [Commits](isaacs/minimatch@v10.1.1...v10.2.4) Updates `minimatch` from 3.1.2 to 3.1.5 - [Changelog](https://github.com/isaacs/minimatch/blob/main/changelog.md) - [Commits](isaacs/minimatch@v10.1.1...v10.2.4) Updates `minimatch` from 9.0.5 to 9.0.9 - [Changelog](https://github.com/isaacs/minimatch/blob/main/changelog.md) - [Commits](isaacs/minimatch@v10.1.1...v10.2.4) --- updated-dependencies: - dependency-name: minimatch dependency-version: 10.2.4 dependency-type: indirect - dependency-name: minimatch dependency-version: 3.1.5 dependency-type: indirect - dependency-name: minimatch dependency-version: 9.0.9 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
no single line ifs please
this should be inside the AdMob class.
comments in English.
no single line ifs please
comments in English
Replace any type with proper AppOpenAdOptions type for better type safety and API consistency.
Moved AppOpenAd Plugin initialization inside the AdMob class.
delete comment
test appOpen
…/AppOpenAdPlugin.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
- Fix standalone: true in Angular demo (was false, breaking bootstrapApplication) - Rename adUnitId → adId in AppOpenAdOptions to match plugin API conventions - Update Android/iOS native plugins to read adId key - Add createAppOpenOptions factory method and APP_OPEN_TESTER_ID to AdOptions - Fix iOS AppOpenAdPlugin to recreate manager when adUnitId changes - Fix web addListener to return Promise<PluginListenerHandle> instead of plain object - Fix docstring: "Load an ad App Open" → "Load an App Open ad" Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Fix failing Android test: stub runOnUiThread to execute runnable synchronously so bannerExecutor.initialize() is verified correctly - Fix README: use adId (not adUnitId) in AppOpenAdOptions example and table, fix grammar "Load an App Open ad", remove extra leading blank line - Fix iOS: clear callback closures after invoking them in delegate methods to avoid unintended retention of CAPPluginCall and notifier references Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Android: add AppOpenAdPluginEvents.kt enum, replace magic strings - Android: pass AdMobPluginError with code/message on failure events - Android: propagate LoadAdError/AdError from manager through callbacks - iOS: propagate Error through onFailed/onFailedToShow callbacks - iOS: include code and message in failure event notifications Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Fix initialization to properly chain promises (wait for AdMob.initialize before calling other methods), preventing demo app crash - Move App Open Ad from app.component to home page with load/show buttons, matching the pattern of other ad types (interstitial, reward) - Add App Open Ad section to demo UI with event listeners - Add App Open screenshots (iOS + Android) to README - Fix AppOpenAdPluginEvents.kt: use const val instead of override val to fix Java interop (private access error) - Use Google test ad ID for App Open (ca-app-pub-3940256099942544/5575463023) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Add per-event typed addListener overloads to AppOpenAdPlugin interface, matching the pattern in InterstitialDefinitions (FailedToLoad/FailedToShow receive AdMobError, others receive void) - iOS: check isAdLoaded() before attempting to show, giving a specific "App Open Ad is not loaded" rejection instead of a generic error - Remove unused createAppOpenOptions/APP_OPEN_TESTER_ID from AdOptions and their corresponding tests (App Open reads adId directly from call) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Add error parameter to FailedToLoad/FailedToShow listener examples in README to match typed API (AdMobError) - Remove unused rootViewController parameter from iOS loadAd method Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- iOS: add AppOpenAdPluginEvents enum (matching other ad types pattern), replace hardcoded event strings with enum rawValues - iOS: remove unused getRootViewController param from loadAppOpen - iOS/Android: include adUnitId in Loaded event and resolve response, matching interstitial/reward behavior - Android: use runOnMain() helper consistently in showAppOpen Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Reverts the removal of AdOptionsFactory.createAppOpenOptions() and APP_OPEN_TESTER_ID, along with their corresponding tests. These were removed per a Copilot suggestion but the maintainer wants them kept for consistency with other ad types. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…otlin Convert both App Open Ad files to idiomatic Kotlin per reviewer request. Uses Kotlin features: named parameters, apply blocks, null safety, fun interface, property accessors, and lambda syntax. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.