File operations: progress, conflicts, drag-drop engine, launching#1
Open
quzopl wants to merge 16 commits into
Open
File operations: progress, conflicts, drag-drop engine, launching#1quzopl wants to merge 16 commits into
quzopl wants to merge 16 commits into
Conversation
…nching Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…cts, launching Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…rror collection Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…le hang) Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Sidebar now emits files_dropped(srcs, dest, mode) instead of copying inline; MainWindow runs it through the threaded engine with progress. Test updated to assert the new delegation contract. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
The same-path guard skipped conflict handling, then _copy_file removed the target (which was the source) before reading it, deleting the file. Now a same-path copy always duplicates with a fresh name and a same-path move is a no-op. Adds regression tests. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
worker.finished/conflict/error were connected to plain closures, which Qt invokes with a direct connection — so dialog/refresh code (and ConflictDialog creation) ran on the worker thread, triggering cross-thread QWidget warnings and risking a crash. Connect to bound methods of the window instead (queued cross-thread delivery); per-transfer state is stashed on the worker and read via sender(). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Makes file operations work like Windows Explorer:
operations/transfer.py): chunked with byte-level progress, same-driverenamefast path, cancel, per-item error collection..desktopfiles and executables/AppImages run (Run/Open/Cancel prompt) instead of throwing "can't run application".Two bugs caught in review and fixed:
Design + plan under
docs/superpowers/.Test Plan
pytest— 126 passed.desktop; check status bar