Skip to content

fix: do not autolink code that is in a link #2972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
maelle merged 3 commits into from
Feb 17, 2026
Merged

fix: do not autolink code that is in a link #2972

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dc02fb2
fix: do not autolink code that is in a link
maelle Feb 12, 2026
1661114
test: add test for code within href
maelle Feb 12, 2026
f4a0e95
news item
maelle Feb 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions NEWS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
# pkgdown (development version)

* do not autolink code that is in a link (href) in Rd files (#2972)

# pkgdown 2.2.0

* Make `build_llm_docs()` more robust to the use of old Pandoc (@nanxstats, @galachad, #2952, #2954)
Expand Down
3 changes: 2 additions & 1 deletion R/rd-html.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,8 @@ as_html.tag_url <- function(x, ...) {
}
#' @export
as_html.tag_href <- function(x, ...) {
a(flatten_text(x[[2]]), href = flatten_text(x[[1]]))
# don't link since we are in a link
a(flatten_text(x[[2]], auto_link = FALSE), href = flatten_text(x[[1]]))
}
#' @export
as_html.tag_email <- function(x, ...) {
Expand Down
7 changes: 7 additions & 0 deletions tests/testthat/test-rd-html.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -319,6 +319,13 @@ test_that("bad specs throw errors", {
})
})

test_that("no autolink in href", {
expect_equal(
rd2html("\\href{https://example.com}{\\code{download.file()}}"),
Copy link
Copy Markdown
Collaborator Author

@maelle maelle Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked that this fails on main 😸

"<a href='https://example.com'><code>download.file()</code></a>"
)
})

# Paragraphs --------------------------------------------------------------

test_that("empty input gives empty output", {
Expand Down