Skip to content

Fix Windows-specific path issue when rendering Quarto vignettes #2983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kv9898 wants to merge 1 commit into
base: main
Choose a base branch
from
+12 −2
Open

Fix Windows-specific path issue when rendering Quarto vignettes #2983

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions R/build-quarto-articles.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,12 +107,22 @@ quarto_render <- function(pkg, path, quiet = TRUE, frame = caller_env()) {
)
write_yaml(quarto_format(pkg), metadata_path)

output_dir <- withr::local_tempdir("pkgdown-quarto-", .local_envir = frame)
# Create the output dir inside the source directory so that we can pass a
# relative path to quarto. This avoids a Windows-specific bug where Quarto
# (Deno) appends absolute paths with drive letters to the project root
# instead of treating them as absolute (e.g. path.join("E:\\src", "C:\\tmp")
# yields "E:\\src\\C:\\tmp" rather than "C:\\tmp").
render_dir <- if (fs::is_dir(path)) path else fs::path_dir(path)
output_dir <- withr::local_tempdir(
"pkgdown-quarto-",
tmpdir = render_dir,
.local_envir = frame
)

quarto::quarto_render(
path,
metadata_file = metadata_path,
quarto_args = c("--output-dir", output_dir),
quarto_args = c("--output-dir", fs::path_rel(output_dir, start = render_dir)),
quiet = quiet,
as_job = FALSE
)
Expand Down
Loading