Skip to content

Comments

Fix #829: Pass ellipsis to download() function#843

Open
tanmaydimriGSOC wants to merge 1 commit intor-lib:mainfrom
tanmaydimriGSOC:fix-download-version-ellipsis
Open

Fix #829: Pass ellipsis to download() function#843
tanmaydimriGSOC wants to merge 1 commit intor-lib:mainfrom
tanmaydimriGSOC:fix-download-version-ellipsis

Conversation

@tanmaydimriGSOC
Copy link

Summary

Fixes #829 - Forward the ... parameter to the download() function call.

Problem

The ... parameter was declared in download_version() signature but never used, preventing users from passing additional download options.

Solution

Pass ... to the download() function call on line 183.

Changes

# Before:
download(path = tempfile(), url = url)

# After:
download(path = tempfile(), url = url, ...)

Testing

# Basic functionality works:
result <- download_version("jsonlite", "1.8.0")

# Extra arguments can now be passed:
result <- download_version("jsonlite", "1.8.0", quiet = TRUE)

Fixes #829.

@tanmaydimriGSOC tanmaydimriGSOC marked this pull request as draft December 10, 2025 11:40
@tanmaydimriGSOC tanmaydimriGSOC marked this pull request as ready for review December 10, 2025 17:31
@tanmaydimriGSOC
Copy link
Author

Note on CI Failures

The current CI failures appear to be pre-existing issues in the repository and are not introduced by this PR. Specifically:

  • Workflow: actions/upload-artifact@v3 is deprecated

  • system_requirements tests: Fail due to RSPM handling of non-existent package names

  • Bioconductor tests: Hard-coded release version mismatch

This PR only updates a single line in R/install-version.R to correctly forward ... in download_version().
It does not touch system requirements, Bioconductor logic, or GitHub workflow files.

Local verification:

devtools::load_all()
result <- download_version("jsonlite", "1.8.0")

This returns the expected download path, confirming the fix works as intended.

Happy to adjust anything related to this specific change !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Inconsistency in download_version function documentation

1 participant