π‘οΈ Sentinel: [CRITICAL] Fix Command injection vulnerabilities by migrating execSync to execFileSync#252
Conversation
Co-authored-by: raccioly <63126795+raccioly@users.noreply.github.com>
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
π¨ Severity: CRITICAL
π‘ Vulnerability: Command injection via
execSync. Multiple instances interpolated user-controlled input (likeprojectDiror arguments) or executed shell pipelines directly viaexecSync().π― Impact: Attackers or compromised dependencies could execute arbitrary system commands by exploiting un-sanitized shell metacharacters (e.g.
&&,|,;).π§ Fix: Replaced all vulnerable
execSynccalls withexecFileSync(), executing binaries directly with arguments passed as an array, bypassing the shell. Emulated shell pipelines (like| wc -l) directly in JavaScript to ensure equivalent behavior.β Verification: Ran
node --test tests/*.test.mjsand passed code review.PR created automatically by Jules for task 13610778824970286427 started by @raccioly