π‘οΈ Sentinel: [CRITICAL] Fix command injection vulnerabilities#255
π‘οΈ Sentinel: [CRITICAL] Fix command injection vulnerabilities#255raccioly wants to merge 1 commit into
Conversation
Migrates uses of `execSync` to `execFileSync` across the CLI commands and validators to mitigate shell command injection vulnerabilities. Arguments are natively separated, and stderr piping is handled synchronously in Node to avoid external shell execution. Unused imports are cleaned up. Co-authored-by: raccioly <63126795+raccioly@users.noreply.github.com>
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
π¨ Severity: CRITICAL
π‘ Vulnerability: Unsanitized variables inside shell execution calls using
execSync. If a directory name or path string contains shell metacharacters (&,;,||), an attacker could easily inject arbitrary code and spawn unauthorized processes.π― Impact: Arbitrary remote code execution (RCE) / command injection. By replacing the shell execution, we bypass the OS shell entirely and pass arguments safely and directly to the binaries.
π§ Fix: Refactored vulnerable invocations across
cli/commands/setup.mjs,cli/commands/score.mjs,cli/ensure-skills.mjs,cli/validators/freshness.mjs, andcli/shared-git.mjsto useexecFileSync. Removed shell features like pipes (| wc -l) and redirections (2>/dev/null), replacing them natively with JavaScript string splitting and native stdio ignores (['pipe', 'pipe', 'ignore']). Cleaned up unusedexecSyncimports from surrounding files.β Verification: Ran test suite (
node --test tests/*.test.mjs) to verify git integrations and CLI initializations operate identically without regressions.PR created automatically by Jules for task 18162553312546432142 started by @raccioly