🛡️ Sentinel: [CRITICAL] Fix command injection via execSync#273
🛡️ Sentinel: [CRITICAL] Fix command injection via execSync#273google-labs-jules[bot] wants to merge 1 commit into
Conversation
…FileSync Refactored multiple instances of `execSync` to use `execFileSync` across the codebase to prevent potential shell interpolation and command injection vulnerabilities when handling user-provided input. Specifically updated: - `isCliAvailable` in `cli/commands/setup.mjs` - `isSpecKitAvailable` in `cli/ensure-skills.mjs` - `getTotalCommits` and `isGitRepo` in `cli/validators/freshness.mjs` - Git commit estimation in `cli/commands/score.mjs` - `isGitRepo` in `cli/shared-git.mjs`
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
🚨 Severity: CRITICAL
💡 Vulnerability: Command injection via shell interpolation in
execSync. Multiple functions invoked shell commands usingexecSyncwith strings that could potentially include user-controlled inputs, allowing for arbitrary command execution if an attacker injected shell metacharacters (e.g.,;,&&,|).🎯 Impact: An attacker could execute arbitrary OS commands with the privileges of the user running the DocGuard CLI.
🔧 Fix: Replaced
execSyncwithexecFileSyncfor affected calls. Changed string-based commands into executable/argument arrays to bypass the shell entirely and prevent interpolation. Handled stderr output natively usingstdio: ['pipe', 'pipe', 'ignore']where required, and replaced shell pipes (like| wc -l) with native JS equivalents.✅ Verification: Ran
node --test tests/*.test.mjsand verified that the functionality remains intact without regressions.PR created automatically by Jules for task 15944941541292326730 started by @raccioly