Skip to content

fix: trait handling, to stop it generating invalid trait names #2063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stevekeay merged 1 commit into from
Jun 3, 2026
+1 −0
Merged

fix: trait handling, to stop it generating invalid trait names #2063

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions python/ironic-understack/ironic_understack/inspect_hook_chassis_model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ def _set_node_traits(task, prefix: str, required_trait: str):
"""Manage the subset of node traits whose names begin with `prefix`."""
node = task.node
existing_traits = node.traits.get_trait_names()
required_trait = prefix + required_trait

required_traits = {x for x in existing_traits if not x.startswith(prefix)}
required_traits.add(required_trait)
Expand Down
Loading