fix: configure Nautobot metrics scraping protocols through chart#2064
Open
skrobul wants to merge 2 commits into
Open
fix: configure Nautobot metrics scraping protocols through chart#2064skrobul wants to merge 2 commits into
skrobul wants to merge 2 commits into
Conversation
This reverts commit 47d2482.
sometimes the django-prometheus returns HTTP 406. The exact headers captured on the wire were: Accept: application/openmetrics-text;version=1.0.0;escaping=allow-utf-8;q=0.6,application/openmetrics-text;version=0.0.1;q=0.5,text/plain;version=1.0.0;escaping=allow-utf-8;q=0.4,text/plain;version=0.0.4;q=0.3,*/*;q=0.2 after some experimentation we found that dropping version=0.4.0 after text/plain fixes the problem. This PR addresses the same underlying issue by specifying the header through spec.scrapeProtocols on the ServiceMonitor resource.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts workaround from #1859 in favor of the upstream fix.
Closes https://rackspace.atlassian.net/browse/PUC-1485